RFR (XS) 8008454: test/runtime/NMT/PrintNMTStatistics is broken

[Christian Törnqvist]

Hi Gerard,

 

The '@run main ClassFileInstaller sun.hotspot.WhiteBox' is somewhat of a hack to get the sun.hotspot.WhiteBox class in a place where we can reach it while running with jtreg. It simply writes the class file to the current directory (scratch directory for the running test).

 

This is then used by '-Xbootclasspath/a:.' to add sun.hotspot.WhiteBox to the bootclasspath. This works on all platforms and is the same pattern used by the other tests using the WhiteBox API.

 

Thanks,

Christian

 

From: Gerard Ziemski 
Sent: den 13 mars 2013 19:47
To: Christian Törnqvist
Cc: hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR (XS) 8008454: test/runtime/NMT/PrintNMTStatistics is broken

 

hi Christian,

I have some basic questions if I may:

What does "@run main ClassFileInstaller sun.hotspot.WhiteBox" do exactly? Why is it need if we already have "@run main PrintNMTStatistics" which seems to be the one actually needed to run PrintNMTStatistics test?

Lastly, why are we hardcoding "-Xbootclasspath/a:."? This surely will not work on say Linux or Mac?


cheers

On 3/13/2013 12:57 PM, Christian Törnqvist wrote:

Hi everyone,

 

Small fix for runtime/NMT/PrintNMTStatistics, first of all it never actually ran the test due to a missing @run tag. When this was fixed it turned out that there were several other things that didn't quite work. I've fixed the command line and parsing to be correct.

 

Tested using jprt on all platforms.

 

Bug:

http://bugs.sun.com/view_bug.do?bug_id=8008454

 

Webrev:

HYPERLINK "http://cr.openjdk.java.net/%7Ectornqvi/webrev/8008454/webrev.00/"http://cr.openjdk.java.net/~ctornqvi/webrev/8008454/webrev.00/

 

Thanks,

Christian

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130313/304b4aa6/attachment.html