Round 3 Code Review request for new MallocMaxTestWords option and fixed test (7030610, 7037122, 7123945)

Ron Durbin ron.durbin at oracle.com
Tue Mar 19 11:02:25 PDT 2013


All,
 
I have a round 3 code review ready for:
 
Round 3 addresses:
- addressed more code review comments from David and Coleen    
 
Web URL: http://cr.openjdk.java.net/~rdurbin/7030610-webrev/2-hsx25/
Internal URL: http://javaweb.us.oracle.com/~rdurbin/7030610-webrev/2-hsx25/
 
7030610 runtime/6878713/Test6878713.sh fails, Error. failed to clean up files after test.
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7030610
https://jbs.oracle.com/bugs/browse/JDK-7030610
 
7037122 runtime/6878713/Test6878713.sh is written incorrectly
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7037122
https://jbs.oracle.com/bugs/browse/JDK-7037122
(This fix only addresses the issues with test runtime/6878713/Test6878713.sh;
7037122 names other tests that are not addressed by this fix)
 
7123945 runtime/6878713/Test6878713.sh require about 2G of
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7123945
https://jbs.oracle.com/bugs/browse/JDK-7123945
 
Summary: Add new diagnostic option -XX:MallocMaxTestWords=NNN and fix 
Test6878713.sh.  Test6878713.sh is a security regression test with four different
failure modes. Three are documented in the defects above and the forth
was found during bug triage. The root cause of these failures can be
traced back to two issues: Inconsistent test condition setup and error handling.
All four defect manifestations are fixed by this set of changes.
 
This latest version is being built and tested in JPRT-hotspotwest.

Ron




More information about the hotspot-runtime-dev mailing list