(JDK-8010396) checking MallocMaxTestWords in testMalloc() function is redundant

Daniel D. Daugherty daniel.daugherty at oracle.com
Wed Mar 20 20:15:00 PDT 2013


I'd be OK with an assert.

Dan


On 3/20/13 7:06 PM, David Holmes wrote:
> I would suggest adding either a comment
>
> // Only called when MallocMaxTestWords > 0
>
> or an assert of that.
>
> David
>
> On 21/03/2013 8:37 AM, Ron Durbin wrote:
>> All,
>>
>> I have a round 0 code review ready for:
>>
>> Web URL: http://cr.openjdk.java.net/~rdurbin/8010396-webrev/0-hsx25/
>> Internal URL: 
>> http://javaweb.us.oracle.com/~rdurbin/8010396-webrev/0-hsx25/
>>
>> 8010396 checking MallocMaxTestWords in testMalloc() function is 
>> redundant.
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010396
>> https://jbs.oracle.com/bugs/browse/JDK-8010396
>>
>>
>> Summary: Remove redundant check of MallocMaxTestWords.
>>



More information about the hotspot-runtime-dev mailing list