(JDK-8010396) checking MallocMaxTestWords in testMalloc() function is redundant

[Ron Durbin]

David,

Thanks for the review

I'm adding the following line to the top of the function:

assert(MallocMaxTestWords > 0, "sanity check");

I won't be sending out a webrev for such a simple change.


Ron

> -----Original Message-----
> From: David Holmes
> Sent: Wednesday, March 20, 2013 7:06 PM
> To: Ron Durbin
> Cc: hotspot-runtime-dev at openjdk.java.net
> Subject: Re: (JDK-8010396) checking MallocMaxTestWords in testMalloc() function is redundant
> 
> I would suggest adding either a comment
> 
> // Only called when MallocMaxTestWords > 0
> 
> or an assert of that.
> 
> David
> 
> On 21/03/2013 8:37 AM, Ron Durbin wrote:
> > All,
> >
> > I have a round 0 code review ready for:
> >
> > Web URL: http://cr.openjdk.java.net/~rdurbin/8010396-webrev/0-hsx25/
> > Internal URL: http://javaweb.us.oracle.com/~rdurbin/8010396-webrev/0-hsx25/
> >
> > 8010396 checking MallocMaxTestWords in testMalloc() function is redundant.
> > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010396
> > https://jbs.oracle.com/bugs/browse/JDK-8010396
> >
> >
> > Summary: Remove redundant check of MallocMaxTestWords.
> >