RFR (M) 8009125: Add NMT tests for Virtual Memory operations

Zhengyu Gu zhengyu.gu at oracle.com
Tue Mar 26 09:57:05 PDT 2013


Hi Christian,

whitebox.cpp: 326 - 331
   Could you please fix the indents

OutputAnalyzerTest.java
   Can you just make those patterns more self-explain? such as [stdin], 
[stdout] and [stderr]?

Other than above, looks good to me.

Thanks,

-Zhengyu


On 3/26/2013 11:44 AM, Christian Tornqvist wrote:
>
> Hi everyone,
>
> Still looking for reviewers for these test changes.
>
> Thanks,
>
> Christian
>
> *From:*hotspot-runtime-dev-bounces at openjdk.java.net 
> [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] *On Behalf Of 
> *Christian Törnqvist
> *Sent:* den 14 mars 2013 18:48
> *To:* hotspot-runtime-dev at openjdk.java.net
> *Subject:* RFR (M) 8009125: Add NMT tests for Virtual Memory operations
>
> Hi everyone,
>
> Adding three new tests for the NMT feature, two of them are for 
> Virtual memory operations (reserve/unreserved and commit/uncommit) and 
> one is a threaded version of the previously added malloc test. Change 
> and added to the NMT WB API's a bit to better support these tests. To 
> be able to parse the output from NMT I added regular expression 
> matching in the utility class OutputAnalyzer (this part is from 
> Yekaterina Kantserova's change to OutputAnalyzer in the JDK repo).
>
> Testing has been done both locally on Windows x64 and with jprt to run 
> these on all platforms.
>
> Bug:
>
> http://bugs.sun.com/view_bug.do?bug_id=8009125
>
> Webrev:
>
> http://cr.openjdk.java.net/~ctornqvi/webrev/8009125/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ectornqvi/webrev/8009125/webrev.00/>
>
> Thanks,
>
> Christian
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130326/f3a64762/attachment.html 


More information about the hotspot-runtime-dev mailing list