RFR(S): JDK-8009552: test/vm/verifier/TestStaticIF.java failing with hs25.0-b20

Bharadwaj Yadavalli bharadwaj.yadavalli at oracle.com
Tue Mar 26 10:40:11 PDT 2013


I would like to request for a review of the elimination of the flag 
-XX:-UseSplitVerifier from the test in 
jdk/test/vm/verifier/TestStaticIF.java as a consequence of the decision 
to deprecate type inference verifier for new class file format versions.

Please note that there were two copies of the test TestStaticIF.java 
with each being tested using different verifiers
a) hotspot/test/runtime/8007736/TestStaticIF.java - was being tested 
with default verifier
b) jdk/test/vm/verifier/TestStaticIF.java - was being tested with old 
verifier i.e., with the option -XX:-UseSplitVerifier

Since TestStaticIF uses Java 8 features, and will be compiled to class 
file version 52, verifying it using old verifier is neither needed nor 
supported. Hence the dual changes.

JBS : https://jbs.oracle.com/bugs/browse/JDK-8009552
Webrev: http://cr.openjdk.java.net/~bharadwaj/8009552/jdk/webrev/

On 3/22/2013 3:27 PM, Bharadwaj Yadavalli wrote:
> Please review the following code changes.
>
> Summary: In accordance with the plan (CCC aproved) to deprecate the 
> type inference verifier for newer class file format versions, this change
>                  a) reverts the additions made to the type inference 
> verifier to verify new class file format versions and
>                  b) deletes the corresponding test .
>
> JBS : https://jbs.oracle.com/bugs/browse/JDK-8009552
> Webrev: http://cr.openjdk.java.net/~bharadwaj/8009552/webrev/

Thanks,

Bharadwaj



More information about the hotspot-runtime-dev mailing list