Request for review: 8010833: Test7116786.java is failing on most configs after fix for 8010667

[harold seigel]

Hi Vladimir,

This would require a lot of changes to the test.  Also, there is another 
test (7154889) that checks that the verifier does or does not throw 
VerifyError for non-zero padding bytes depending on class file version.  
So, I don't think that modifying Test7116786 would provide any 
additional test coverage.

Thanks, Harold


On 3/26/2013 5:13 PM, Vladimir Kozlov wrote:
> Harold,
>
> Is it possible to set 'testable' parameter for case58 based on class 
> file version?
>
> Thanks,
> Vladimir
>
> On 3/26/13 1:15 PM, harold seigel wrote:
>> Please review the following small change to fix bug 8010833
>>
>> Summary: The fix for 8010667 allows non-zero padding bytes for
>> lookupswitch and tableswitch opcodes.  Previously, these had to be
>> zero.  Test7116786 is now incorrect because it expects a VerifyError
>> exception for non-zero padding bytes for lookupswitch and tableswitch
>> opcodes.
>>
>> Open webrev at http://cr.openjdk.java.net/~hseigel/bug_8010833/
>> <http://cr.openjdk.java.net/%7Ehseigel/bug_8010833/>
>>
>> Bug link at http://bugs.sun.com/view_bug.do?bug_id=8010833
>>
>> The change was tested by running the test and seeing that it passes.
>>
>> Thanks, Harold