RFR (s): 8009531: Crash when redefining class with annotated method

[Daniel D. Daugherty]

Forgot to comment on the test...


On 3/26/13 4:11 PM, Coleen Phillimore wrote:
> Summary: Neglected to copy the annotations in clone_with_new_data when 
> they were moved to ConstMethod.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8009531/
> bug link at http://bugs.sun.com/view_bug.do?bug_id=8009531
>
> Also. please review JDK test modified to test that this crash is fixed 
> (will check in in two weeks).
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8009531_jdk
test/java/lang/instrument/RedefineMethodWithAnnotations.sh
     No comments.

test/java/lang/instrument/RedefineMethodWithAnnotationsTarget.java
     The comment says:

     25  * The first version of this class. The second version is in
     26  * RedefineMethodWithAnnotationsTarget_2.java.

     The code says:

     31         System.out.println("Second version of 
annotatedMethod(String)");
     36         System.out.println("Second version of 
annotatedMethod(int)");

     Seems backwards, perhaps just to me.

test/java/lang/instrument/RedefineMethodWithAnnotationsTarget_2.java
     The comment says:

     25  * This is the second version of this class. The first version is in
     26  * RedefineMethodWithAnnotationsTarget.java.

     The code says:

     33         System.out.println("First version of annotatedMethod(int)");
     38         System.out.println("First version of 
annotatedMethod(String)");

     Also seems backwards.

Dan