RFR (S): 8013574: PrintMalloc conflicts with the command line parsing

Bengt Rutisson bengt.rutisson at oracle.com
Wed May 1 13:52:06 PDT 2013


Hi all,

Could I have a couple of reviews for this small fix?

http://cr.openjdk.java.net/~brutisso/8013574/webrev.00/

The problem is that Arguments::add_string() updates the count ( 
_num_jvm_args) before it adds the actual entry to the bldarray ( 
_jvm_args_array). This is a problem since the allocation might 
eventually lead to a call to print_jvm_args_on(), which relies on 
_num_jvm_args and _jvm_args_array being in sync.

The proposed fix updates the count after the corresponding entry has 
been allocated.

Thanks,
Bengt
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130501/8eabcd31/attachment-0001.html 


More information about the hotspot-runtime-dev mailing list