RFR (S): 8013574: PrintMalloc conflicts with the command line parsing

Bengt Rutisson bengt.rutisson at oracle.com
Thu May 2 13:39:45 PDT 2013


Thanks Tao, John and Thomas!

Pushing this now.

Bengt

On 5/2/13 9:21 PM, Thomas Schatzl wrote:
> Hi,
>
> On Thu, 2013-05-02 at 11:38 -0700, John Cuthbertson wrote:
>
>> On 5/1/2013 1:52 PM, Bengt Rutisson wrote:
>>> Hi all,
>>>
>>> Could I have a couple of reviews for this small fix?
>>>
>>> http://cr.openjdk.java.net/~brutisso/8013574/webrev.00/
>>>
>>> The problem is that Arguments::add_string() updates the count
>>> ( _num_jvm_args) before it adds the actual entry to the bldarray
>>> ( _jvm_args_array). This is a problem since the allocation might
>>> eventually lead to a call to print_jvm_args_on(), which relies on
>>> _num_jvm_args and _jvm_args_array being in sync.
>>>
>>> The proposed fix updates the count after the corresponding entry has
>>> been allocated.
> Looks good.
>
>   Thomas
>



More information about the hotspot-runtime-dev mailing list