Request for review: 8013648: guarantee(VerifyBeforeGC || VerifyDuringGC || VerifyBeforeExit || VerifyAfterGC) failed: too expensive

[Ron Durbin]

Coleen

 

Pardon me I do not mean to rain on the parade, but I thought the minimum unit testing required 2 platforms and one has to be windows.

Am I correct or not?

 

Ron

 

From: Coleen Phillimore 
Sent: Thursday, May 02, 2013 3:26 PM
To: hotspot-runtime-dev at openjdk.java.net
Subject: Re: Request for review: 8013648: guarantee(VerifyBeforeGC || VerifyDuringGC || VerifyBeforeExit || VerifyAfterGC) failed: too expensive

 


Looks good.
Coleen

On 05/02/2013 03:15 PM, harold seigel wrote:

Hi,

Please review this fix for bug 8013648.

Summary:  The code is calling the wrong overloaded SystemDictionary::find_class() function.  Instead of calling this one:

// Used for assertions and verification only
Klass* SystemDictionary::find_class(Symbol* class_name, ClassLoaderData* loader_data) {
  #ifndef ASSERT
  guarantee(VerifyBeforeGC      ||
            VerifyDuringGC      ||
            VerifyBeforeExit    ||
            VerifyDuringStartup ||
            VerifyAfterGC, "too expensive");
  #endif
             ...

It should be calling the SystemDictionary::find_class() that takes four arguments.

Open webrev at HYPERLINK "http://cr.openjdk.java.net/%7Ehseigel/bug_8013648/"http://cr.openjdk.java.net/~hseigel/bug_8013648/

Bug link at http://bugs.sun.com/view_bug.do?bug_id=8013648

Testing was done with JCK lang and VM tests, JTREG tests, and ute vm.quick.testlist and vm.mlvm.testlist.  Tests were run with both -client and -server on 32 and 64 bit Linux.

Thanks, Harold

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130502/5353f96a/attachment.html