Request for review:8013067:Zero builds are broken after 8010862
Vladimir Kozlov
vladimir.kozlov at oracle.com
Mon May 6 10:13:43 PDT 2013
Jiangli,
I understand that you followed existing code pattern using macros. But
it is very difficult to debug, especially nested macros.
I don't think we need separate macros just for 1 or 2 uses.
I would like to see all these macros gone (GET_METHOD_COUNTERS,
*_COUNT(mcs), INCR_*_COUNT(mcs)).
Thanks,
Vladimir
On 5/6/13 9:19 AM, Jiangli Zhou wrote:
> Christian has reviewed the change. Could I have one more review?
>
> Thanks,
> Jiangli
>
> On 04/30/2013 04:31 PM, Jiangli Zhou wrote:
>> Hi,
>>
>> Please review the following change for 8013067:
>>
>> http://cr.openjdk.java.net/~jiangli/8013067/webrev.00/
>>
>> Thanks,
>>
>> Jiangli
>
More information about the hotspot-runtime-dev
mailing list