Request for review:8013067:Zero builds are broken after 8010862
Coleen Phillimore
coleen.phillimore at oracle.com
Mon May 6 10:57:50 PDT 2013
I had the same thought about the macros in that function but since the
ones Jiangli added were short and seemed to rely on other macros, I
didn't think they'd be easily fixed.
Coleen
On 05/06/2013 01:40 PM, Jiangli Zhou wrote:
> Hi Vladimir,
>
> I was considering whether to switch to functions, but decided not to
> alter the existing code too much. Thanks a lot for the review and
> feedback. I will replace the macros.
>
> Jiangli
>
> On 05/06/2013 10:13 AM, Vladimir Kozlov wrote:
>> Jiangli,
>>
>> I understand that you followed existing code pattern using macros.
>> But it is very difficult to debug, especially nested macros.
>> I don't think we need separate macros just for 1 or 2 uses.
>>
>> I would like to see all these macros gone (GET_METHOD_COUNTERS,
>> *_COUNT(mcs), INCR_*_COUNT(mcs)).
>>
>> Thanks,
>> Vladimir
>>
>> On 5/6/13 9:19 AM, Jiangli Zhou wrote:
>>> Christian has reviewed the change. Could I have one more review?
>>>
>>> Thanks,
>>> Jiangli
>>>
>>> On 04/30/2013 04:31 PM, Jiangli Zhou wrote:
>>>> Hi,
>>>>
>>>> Please review the following change for 8013067:
>>>>
>>>> http://cr.openjdk.java.net/~jiangli/8013067/webrev.00/
>>>>
>>>> Thanks,
>>>>
>>>> Jiangli
>>>
>
More information about the hotspot-runtime-dev
mailing list