Request for review: 8007018 RFE: -XX:+UseLargePages does not work with CDS

[Coleen Phillimore]

Yes, this change is good.  Thank you for doing this!!
Coleen

On 05/06/2013 03:53 PM, Christian Tornqvist wrote:
> Awesome! Change looks good and thanks for doing the extra testing :)
>
> Thanks,
> Christian
>
> -----Original Message-----
> From: harold seigel [mailto:harold.seigel at oracle.com]
> Sent: den 6 maj 2013 15:26
> To: Christian Tornqvist
> Cc: hotspot-runtime-dev at openjdk.java.net
> Subject: Re: Request for review: 8007018 RFE: -XX:+UseLargePages does not work with CDS
>
> Hi Christian,
>
> I ran garbage collection tests with "-XX:+UseLargePages -Xshare:on" on Windows 7 without problems.
>
> Thanks, Harold
>
> On 5/3/2013 5:22 PM, Christian Tornqvist wrote:
>> Hi Harold,
>>
>> Could you do a run with largepages and CDS on Windows as well? Please let me know if you need help setting it up/running it.
>>
>> Thanks,
>> Christian
>>
>> -----Original Message-----
>> From: hotspot-runtime-dev-bounces at openjdk.java.net
>> [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of
>> harold seigel
>> Sent: den 3 maj 2013 13:31
>> To: hotspot-runtime-dev at openjdk.java.net
>> Subject: Request for review: 8007018 RFE: -XX:+UseLargePages does not
>> work with CDS
>>
>> Hi,
>>
>> Please review this fix for bug 8007018.
>>
>> There is no reason why UseLargePages does not work with CDS.  So, the fix is to remove the explicit restriction of UseLargePages with CDS from arguments.cpp and then test.
>>
>> Testing was done with -XX:+UseLargePages -X:share<dump|on> on 64 bit Linux and 64 bit Solaris using JCK lang and vm tests and applicable UTE vm.quick.testlist and vm.mlvm.testlist tests.
>>
>> Open webrev at http://cr.openjdk.java.net/~hseigel/bug_8007018/
>> <http://cr.openjdk.java.net/%7Ehseigel/bug_8007018/>
>>
>> Bug link at http://bugs.sun.com/view_bug.do?bug_id=8007018
>>
>> Thanks, Harold
>>
>