RFR(S) - JDK-8013875: Incorrect vtable index being set during methodHandle creation for static methods

[John Rose]

Because a 'vmindex' of -1 is a sentinel value, use a manifest constant known to be different from 'nonvirtual_vtable_index'.
  - int vmindex = -1;
  + int vmindex = Method::invalid_vtable_index;

(It was -1 before simply as a garbage value likely to raise an assertion if it leaked through.)

Note:  We will need to clean this up after CallInfo is cleaned up to handle the new linkage results.  Does the CallInfo cleanup have a bug ID yet?  If not I will file a bug for it.

— John

On May 6, 2013, at 11:43 AM, Bharadwaj Yadavalli <bharadwaj.yadavalli at oracle.com> wrote:

> 
> [Updated request for review]
> 
> Changes to address https://jbs.oracle.com/bugs/browse/JDK-8006267 included modifications to methodHandles code.
> 
> John Rose pointed out that these changes are incorrect as static methods do not use vtable or itable indices. I made the necessary changes with his help.
> 
> I ran jtreg compiler, runtime and java/lang/invoke tests, JPRT, nashorn tests and vm.quick.testlist with no new failures.
> 
> Please review the changes.
> 
> Thanks,
> 
> Bharadwaj
> 
> JBS: https://jbs.oracle.com/bugs/browse/JDK-8013875
> Webrev: http://cr.openjdk.java.net/~bharadwaj/8013875/webrev/
> 
> On 5/5/2013 11:27 PM, Bharadwaj Yadavalli wrote:
>> 
>> On 5/5/2013 8:22 AM, Bharadwaj Yadavalli wrote:
>>> 
>>> On 5/3/2013 11:53 PM, Christian Thalinger wrote:
>>>> On May 3, 2013, at 6:32 PM, Bharadwaj Yadavalli <bharadwaj.yadavalli at oracle.com> wrote:
>>>> 
>>>>> I ran jtreg compiler and runtime; JPRT. 
>>>> Since it changes method handle code you should at least run the jtreg tests in jdk/test/java/lang/invoke and some Nashorn tests.
>>> 
>>> How do I run Nashorn tests?
>>> 
>> 
>> Never mind. I figured out. I ran both j.l.invoke (no new failures) and nashorn test suite (no failures). I am running a few other tests as well.
>> 
>> Will send an update once those tests complete successfully.
>> 
>> Thanks,
>> 
>> Bharadwaj
>> 
>> 
>