RFR: 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes

[Staffan Larsen]

On 6 maj 2013, at 23:58, John Rose <john.r.rose at oracle.com> wrote:

> On May 2, 2013, at 1:50 AM, Staffan Larsen <staffan.larsen at oracle.com> wrote:
> 
>> JvmtiClassFileReconstituter does not create BootstrapMethod attributes when re-creating a class for retransformation. This fix uses the operands in the constant pool to re-create the BootstrapMethod attributes in the class file.
>> 
>> webrev: http://cr.openjdk.java.net/~sla/8009615/webrev.00/
>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009615
>> 
>> Testing done: java/lang/instrument, com/sun/jdi, nsk.quick-jvmti.testlist
>> 
>> I have not written a regression test since this was found by running the existing java/lang/instrument/IsModifiableClassAgent.java test.
> 
> Good.  And I agree with Serguei's comments.
> 
> One more typo: write_boostrapmethod_attribute should be write_bootstrapmethod_attribute.  "Boostrap" sounds like it has to do with astronaut rappers, or maybe ghost trappers.

Oops. I had already pushed the change. Here is an additional webrev for the spelling error (found one more as well).

http://cr.openjdk.java.net/~sla/8014044/webrev.00/

Thanks,
/Staffan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130507/e5e95140/attachment-0001.html