Review request for JDK-8009729: Refix hotspot jni_<cpu>.h JNIEXPORT and JNIIMPORT definitions to match jdk version

Eric McCorkle eric.mccorkle at oracle.com
Tue May 7 09:01:29 PDT 2013


Can someone give this a look so it can go in?

On 05/07/13 00:55, David Holmes wrote:
> On 4/05/2013 1:29 AM, Eric McCorkle wrote:
>> Does anyone have any comments on this patch, or is it good to go?
> 
> This looks good to go - it is consistent with the changes already in the
> JDK jni_md.h files.
> 
> You need a second reviewer though (small 'r')
> 
> David
> 
>> On 05/01/13 16:56, Eric McCorkle wrote:
>>> Hello,
>>>
>>> Please review this patch, which updates the definitions of JNIEXPORT and
>>> JNIIMPORT to use the __has_attribute macro.
>>>
>>> The webrev is here
>>> http://cr.openjdk.java.net/~emc/8009729/
>>>
>>> Thanks,
>>> Eric
>>>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: eric_mccorkle.vcf
Type: text/x-vcard
Size: 314 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130507/8fc2d344/eric_mccorkle.vcf 


More information about the hotspot-runtime-dev mailing list