Review request for JDK-8009729: Refix hotspot jni_<cpu>.h JNIEXPORT and JNIIMPORT definitions to match jdk version

[Daniel D. Daugherty]

 > http://cr.openjdk.java.net/~emc/8009729/

src/cpu/sparc/vm/jni_sparc.h
src/cpu/x86/vm/jni_x86.h
cpu/zero/vm/jni_zero.h
     No comments on the above files.

     I sanity checked against src/solaris/javavm/export/jni_md.h
     in the 'jdk' repo and the changes are a match.

Thumbs up!


Dan (OpenJDK user == dcubed)


On 5/7/13 10:01 AM, Eric McCorkle wrote:
> Can someone give this a look so it can go in?
>
> On 05/07/13 00:55, David Holmes wrote:
>> On 4/05/2013 1:29 AM, Eric McCorkle wrote:
>>> Does anyone have any comments on this patch, or is it good to go?
>> This looks good to go - it is consistent with the changes already in the
>> JDK jni_md.h files.
>>
>> You need a second reviewer though (small 'r')
>>
>> David
>>
>>> On 05/01/13 16:56, Eric McCorkle wrote:
>>>> Hello,
>>>>
>>>> Please review this patch, which updates the definitions of JNIEXPORT and
>>>> JNIIMPORT to use the __has_attribute macro.
>>>>
>>>> The webrev is here
>>>> http://cr.openjdk.java.net/~emc/8009729/
>>>>
>>>> Thanks,
>>>> Eric
>>>>