RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return

[David Holmes]

Ron,

On 8/05/2013 10:31 PM, Ron Durbin wrote:
> Change looks good, can tell me what tests were run?

This kind of change requires very limited testing - JPRT testing will 
suffice. Adding a NULL check with a vm_exit_out_of_memory is not 
something that needs extensive testing applied.

> Were able create a unit test that triggers the failure ?

You would need a modified VM to trigger a malloc failure at any 
particular allocation site.

David

> Thx Ron
>
>> -----Original Message-----
>> From: Staffan Larsen
>> Sent: Wednesday, May 08, 2013 6:17 AM
>> To: Rickard Bäckman
>> Cc: serviceability-dev at openjdk.java.net serviceability-dev at openjdk.java.net; hotspot-runtime-
>> dev at openjdk.java.net
>> Subject: Re: RFR(XS): 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return
>>
>> Looks good.
>>
>> /Staffan
>>
>> On 8 maj 2013, at 13:08, Rickard Bäckman <rickard.backman at oracle.com> wrote:
>>
>>> Hi,
>>>
>>> please review this small change.
>>> The change adds a check to see the result of a malloc() and aborts the VM with an out of memory
>> error.
>>>
>>> Webrev: http://cr.openjdk.java.net/~rbackman/8008255/
>>> Bug: http://bugs.sun.com/view_bug.do?bug_id=8008255
>>>
>>> Thanks
>>> /R
>>>
>>