Request for review: 8007018 RFE: -XX:+UseLargePages does not work with CDS

[harold seigel]

Hi David,

What I found out was that CDS used to be part of Permgen.  So remapping 
with LargePages was probably going to break it badly.

Thanks, Harold

On 5/7/2013 11:08 PM, David Holmes wrote:
> On 8/05/2013 12:41 AM, harold seigel wrote:
>> Hi David,
>>
>> The UseLargePages and related options affect the Java heap. They do not
>> affect the shared archive.  Just to be sure, I created the shared
>> archive with -XX:+UseLargePages and then ran tests with
>> -XX:-UseLargePages -Xshare:on without problems.  I also did the reverse
>> testing.
>
> Okay thanks. Looks fine.
>
> Do we know why it was originally disabled? I couldn't follow the trail 
> through the sccs history.
>
> David
>
>> Thanks, Harold
>>
>> On 5/7/2013 12:28 AM, David Holmes wrote:
>>> Hi Harold,
>>>
>>> Is there any requirement that the VM that generates the shared
>>> archive, and the VMs that use it, run with the same value of
>>> UseLargePages (and other large-page related values) ?
>>>
>>> Thanks,
>>> David
>>>
>>> On 4/05/2013 3:31 AM, harold seigel wrote:
>>>> Hi,
>>>>
>>>> Please review this fix for bug 8007018.
>>>>
>>>> There is no reason why UseLargePages does not work with CDS. So, the
>>>> fix is to remove the explicit restriction of UseLargePages with CDS 
>>>> from
>>>> arguments.cpp and then test.
>>>>
>>>> Testing was done with -XX:+UseLargePages -X:share<dump|on> on 64 bit
>>>> Linux and 64 bit Solaris using JCK lang and vm tests and applicable 
>>>> UTE
>>>> vm.quick.testlist and vm.mlvm.testlist tests.
>>>>
>>>> Open webrev at http://cr.openjdk.java.net/~hseigel/bug_8007018/
>>>> <http://cr.openjdk.java.net/%7Ehseigel/bug_8007018/>
>>>>
>>>> Bug link at http://bugs.sun.com/view_bug.do?bug_id=8007018
>>>>
>>>> Thanks, Harold
>>