Request for review: 8014138: Add VM option to facilitate the writing of CDS tests

[Zhengyu Gu]

Thanks.

set_shared_archive_path more like get_shared_archive_path() ....

Other than that, look good to me.

-Zhengyu

On 5/9/2013 2:56 PM, harold seigel wrote:
> Hi Zhengyu,
>
> Thanks for looking at this.  Comments inline.
>
> Harold
>
> On 5/9/2013 2:35 PM, Zhengyu Gu wrote:
>> Hi Harold,
>>
>> arguments.cpp
>>
>> 3186 - 3187: why not  strcat(shared_archive_path, "classes.jsa")
> I'll clean that up.
>>
>> Also, I don't see where SharedArchiveFile is used.
> In function set_shared_archive_path(), if SharedArchiveFile is null 
> then the original archive file path is used.
> Else the value of SharedArchiveFile is copied to shared_archive_path 
> and returned as the function value.
>>
>> Thanks,
>>
>> -Zhengyu
>>
>>
>>
>> On 5/9/2013 1:44 PM, harold seigel wrote:
>>> Hi,
>>>
>>> Please review this fix for bug 8014138.
>>>
>>> This enhancement adds a new diagnostic option, 
>>> "-XX:SharedArchiveFile=<file-path>" that takes a string specifying 
>>> the path of the shared archive file.  Note that if the option is 
>>> specified when the shared archive is written, then it must be used 
>>> when the shared archive is being read (i.e. -Xshare:on).
>>>
>>> This change was tested with JCK lang and vm tests, UTE 
>>> vm.quick.testlist and vm.mlvm.testlist tests, and jtreg tests. In 
>>> addition, the test included in this change was run on Linux 32/64, 
>>> Solaris 32/64, Windows 7, and Mac OS.
>>>
>>> Open webrev at http://cr.openjdk.java.net/~hseigel/bug_8014138/ 
>>> <http://cr.openjdk.java.net/%7Ehseigel/bug_8014138/>
>>>
>>> Bug link at http://bugs.sun.com/view_bug.do?bug_id=8014138
>>>
>>> Thanks, Harold
>>
>