RFR (S): CR 8012939: @Contended doesn't work correctly with inheritance

Aleksey Shipilev aleksey.shipilev at oracle.com
Fri May 10 11:16:50 PDT 2013


Third time's a charm!
Please review!

-Aleksey.

On 05/08/2013 03:44 PM, Aleksey Shipilev wrote:
> Another friendly reminder. Please review!
> 
> This seems to start being critical if we want to annotate some of the
> core classes (e.g. Thread) with @Contended.
> 
> -Aleksey.
> 
> On 05/03/2013 12:40 PM, Aleksey Shipilev wrote:
>> Friendly reminder.
>>
>> -Aleksey.
>>
>> On 04/29/2013 02:53 PM, Aleksey Shipilev wrote:
>>> Hi,
>>>
>>> This is the fix for the bug found during SQE testing:
>>>    http://cr.openjdk.java.net/~shade/8012939/webrev.00/
>>>
>>> The essence of the bug is that the padding in the superclass may be
>>> disregarded by the subclasses due to mishap in the instance size
>>> calculation. This is the corner case, and we don't know whether anybody
>>> had been burned on this yet.
>>>
>>> The patch fixes up the instance size handling, as well as prunes the
>>> source of the original error (reusing next_nonstatic_type_offset was
>>> confusing).
>>>
>>> Testing:
>>>   - full JPRT cycle
>>>   - adhoc testing with Linux x86_64/fastdebug and Test8012939
>>>
>>> -Aleksey.
>>>
>>
> 



More information about the hotspot-runtime-dev mailing list