RFR 8005056: NPG: Crash after redefining java.lang.Object

[Coleen Phillimore]

On 5/10/2013 2:33 AM, serguei.spitsyn at oracle.com wrote:
> Hi Coleen,
>
> The fix looks good.
> At least, I do not see any issues.
>
> Is the test from the webrev failing without your fix?

Yes, it was failing.   Calling java/lang/Object method on a basic type 
array was crashing.  I added this comment to the test:

  * Test to redefine java/lang/Object and verify that it doesn't crash 
on vtable
  * call on basic array type.

Thanks for reviewing the change!
Coleen

>
> Thanks,
> Serguei
>
> On 5/8/13 7:51 PM, Coleen Phillimore wrote:
>> Summary: Need to walk array class vtables replacing old methods too 
>> if j.l.o is redefined
>>
>> Array methods aren't in the SystemDictionary and the code that was 
>> there didn't walk the basic type array classes defined in universe.   
>> It also walked the same classes more than once.  Use the 
>> ClassLoaderDataGraph class walking instead.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8005056/
>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8005056
>>
>> Tested with all redefine classes tests, jdk java/lang/instrument 
>> tests, hotspot jtreg tests.
>>
>> Thanks,
>> Coleen
>>
>