RFR (S): 8008169: test/runtime/7158804/Test7158804.sh has bad copyright header

[Leonid Mesnik]

Thank you for pointing this.
I've missed it. I'll file RFE for naming unification.

Leonid
On 05/14/2013 09:26 PM, Christian Tornqvist wrote:
>
> The rest of the tests for command-line options are already in 
> runtime/CommandLine
>
> Thanks,
>
> Christian
>
> *From:*hotspot-runtime-dev-bounces at openjdk.java.net 
> [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] *On Behalf Of 
> *Leonid Mesnik
> *Sent:* den 14 maj 2013 10:50
> *To:* Mikhailo Seledtsov
> *Cc:* hotspot-runtime-dev at openjdk.java.net
> *Subject:* Re: RFR (S): 8008169: test/runtime/7158804/Test7158804.sh 
> has bad copyright header
>
> Hi
> Not a reviewer. Thank you for improving test. Just little comment 
> about naming.
>
> Thomas just added the test against command-line for gc options which 
> have names like this:
> test/gc/arguments/TestG1HeapSizeFlags.java
>
> Probably it make a sense to use same name 'arguments' for command-line 
> arguments tests in
> all components. What do you think about this?
>
> Leonid
> *
> *On 05/14/2013 06:16 PM, Mikhailo Seledtsov wrote:
>
>     Greetings,
>
>       Could you, please, review a small change of a test code?
>
>     The original bug prompted for a simple fix of a copyright string.
>     However I thought test base would be better served by re-writing
>     this test case in Java, which also fixes copyright notice :)
>
>     The bug description can be found at:
>
>     http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008169
>
>     The webrev is at:
>
>     http://cr.openjdk.java.net/~ctornqvi/webrev/8008169/webrev.00/
>     <http://cr.openjdk.java.net/%7Ectornqvi/webrev/8008169/webrev.00/>
>
>     I have verified my changes by running this test against
>     jdk8_build62 (which failed as expected), and then against
>     jdk8_build63 which passed. This test case was written for a bug
>     that existed in jdk8_build62 and was fixed in jdk8_build63.
>
>     Thank you,
>
>     Misha
>
>
>
>
> -- 
> Leonid Mesnik
> JVM SQE


-- 
Leonid Mesnik
JVM SQE

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130514/87445e2c/attachment-0001.html