RFR (S): 8008169: test/runtime/7158804/Test7158804.sh has bad copyright header

[Christian Tornqvist]

Looks good! Thanks for re-writing the test to be platform independent :)

 

Thanks,

Christian

 

From: hotspot-runtime-dev-bounces at openjdk.java.net
[mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of Mikhailo
Seledtsov
Sent: den 14 maj 2013 10:17
To: hotspot-runtime-dev at openjdk.java.net
Subject: RFR (S): 8008169: test/runtime/7158804/Test7158804.sh has bad
copyright header

 

Greetings,

 

  Could you, please, review a small change of a test code?

The original bug prompted for a simple fix of a copyright string. However I
thought test base would be better served by re-writing this test case in
Java, which also fixes copyright notice :)

 

The bug description can be found at: 

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008169

The webrev is at: 

http://cr.openjdk.java.net/~ctornqvi/webrev/8008169/webrev.00/

 

I have verified my changes by running this test against jdk8_build62 (which
failed as expected), and then against jdk8_build63 which passed. This test
case was written for a bug that existed in jdk8_build62 and was fixed in
jdk8_build63. 

 

Thank you,

Misha

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130514/c981d780/attachment.html