RFR (S): 8008169: test/runtime/7158804/Test7158804.sh has bad copyright header

[Christian Tornqvist]

Yes, they each get their own scratch folder (scratch\1, scratch\2 and so
on).

 

Thanks,

Christian

 

From: hotspot-runtime-dev-bounces at openjdk.java.net
[mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of Coleen
Phillimore
Sent: den 14 maj 2013 18:05
To: hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR (S): 8008169: test/runtime/7158804/Test7158804.sh has bad
copyright header

 


Misha,
This looks good.  Thank you for rewriting it in Java.  This is a nice
improvement.  If another test runs concurrently with this one, will it get
the bogus .hotspotrc file or are all the tests run in their own directories?
thanks,
Coleen

On 05/14/2013 10:16 AM, Mikhailo Seledtsov wrote:

Greetings,

 

  Could you, please, review a small change of a test code?

The original bug prompted for a simple fix of a copyright string. However I
thought test base would be better served by re-writing this test case in
Java, which also fixes copyright notice :)

 

The bug description can be found at: 

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008169

The webrev is at: 

http://cr.openjdk.java.net/~ctornqvi/webrev/8008169/webrev.00/
<http://cr.openjdk.java.net/%7Ectornqvi/webrev/8008169/webrev.00/> 

 

I have verified my changes by running this test against jdk8_build62 (which
failed as expected), and then against jdk8_build63 which passed. This test
case was written for a bug that existed in jdk8_build62 and was fixed in
jdk8_build63. 

 

Thank you,

Misha

 

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130515/e240e028/attachment.html