review request (S) - 8014611: reserve_and_align() assumptions

[Thomas Schatzl]

Hi,

On Thu, 2013-05-23 at 03:59 -0700, John Coomes wrote:
> Thomas Schatzl (thomas.schatzl at oracle.com) wrote:
> > Hi,
> > 
> > On Tue, 2013-05-21 at 14:27 -0700, John Coomes wrote:
> > > Bengt Rutisson (bengt.rutisson at oracle.com) wrote:
> > > > On 5/21/13 2:46 AM, John Coomes wrote:
> > > 
>
> Thanks for taking a look.
> 
> The invariant is/was _raw_base and _raw_size are only used/touched
> when os::can_release_partial_memory() returns false.  So they could
> contain junk, but the junk was never used.

Yes, that was what I saying.

> 
> Nevertheless, I've updated the code to always init them to NULL/0, and
> only store non-NULL/0 values when os::can_release_partial_region()
> returns false.  See the same url:
> 
> 	http://cr.openjdk.java.net/~jcoomes/8014611-reserve-and-align/
> 
> I'm going to push this.

Looks good.

Thomas