RFR (S) CR 8015270: @Contended: fix multiple issues in the layout code

[Vladimir Kozlov]

On 5/23/13 5:00 AM, Aleksey Shipilev wrote:
> Hi,
>
> Here's the merged changeset:
>    http://cr.openjdk.java.net/~shade/8015270/webrev.01/

Looks good to me.

Thanks,
Vladimir

>
> Summary:
>   - has_nonstatic_fields bug fixed
>   - oop_map overrun is fixed
>   - parsed_annotations->in_contended() cleaned up
>   - asserts added to cover the regression tests
>
> Testing:
>   - all HS regression tests
>       (have a few environmental failures, but nothing new)
>   - full JPRT cycle against hotspot-rt
>       (passes OK)
>
> Still no luck getting vm.quick to work in my environment even for the
> JDK 8 EA builds, I'll update with the report later. Early comments are
> welcome anyway.
>
> Coleen, I got your idea of incrementing fac[...] a try, but it turns
> more messy than current code (fac is actually coming from outside to
> layout_fields, and I think it is a sane idea to keep it the same).
>
> -Aleksey.
>