RFR #2 (S) CR 8015270: @Contended: fix multiple issues in the layout code

Aleksey Shipilev aleksey.shipilev at oracle.com
Mon May 27 10:53:46 PDT 2013


On 05/27/2013 09:24 PM, Daniel D. Daugherty wrote:
> On 5/25/13 1:35 AM, Aleksey Shipilev wrote:
>> Here's the merged changeset:
>>    http://cr.openjdk.java.net/~shade/8015270/webrev.01/
> 
> Thumbs up!

Thanks for the review!

> hotspot/test/runtime/contended/HasNonStatic.java
> hotspot/test/runtime/contended/OopMaps.java
>     It would be good to update JDK-8015270 with information about
>     what happens when these tests are run on a VM/JDK that does
>     not have the fix. That will help with the bug fix verification
>     process.

I can do that. Is there an example of this practice somewhere in our
code? Random sampling in hotspot/test yield no result. I'd like to see
some uniform way we record this info in the regression tests -- will the
Javadoc on test class suffice?


> JBS/administrivia issues:
> 
> I bumped JDK-8015270 to P2 since JDK-8014886 is a P2.

Oh, I think JDK-8014886 is P3, because the likelihood is low, and there
is the workaround with either emulating @C on fields with class-level
@C, or some other trick. I have not changed the priority for the closed
issue, because did not thought it is relevant anymore. Please consider
setting the priority back; I can do that along the change below:

> I believe the correct 'duplicate state' is:
> 
>     JDK-8015270 duplicates JDK-8014886
>     JDK-8015270 duplicates JDK-8014964
> 
> since JDK-8015270 is the bug that is going to be used to get
> the work done.

Hmmm... I think you are right. Do you want me to relink these appropriately?

-Aleksey.


More information about the hotspot-runtime-dev mailing list