RFR #2 (S) CR 8015270: @Contended: fix multiple issues in the layout code
Aleksey Shipilev
aleksey.shipilev at oracle.com
Mon May 27 12:16:23 PDT 2013
On 05/27/2013 10:51 PM, Daniel D. Daugherty wrote:
> On 5/27/13 11:53 AM, Aleksey Shipilev wrote:
>> On 05/27/2013 09:24 PM, Daniel D. Daugherty wrote:
>>> On 5/25/13 1:35 AM, Aleksey Shipilev wrote:
>>>> Here's the merged changeset:
>>>> http://cr.openjdk.java.net/~shade/8015270/webrev.01/
>>> Thumbs up!
>> Thanks for the review!
>
> No problem. I forgot to say that the unified review webrev didn't
> appear to be tangled at all (to me).
Yeah, well, my puristic self anyway thinks "one issue" = "one CR" is a
better idea. :) Do you want the generated changeset for this webrev? (I
also want to tickle my paranoia a little and suggest we wait for the
nightly cycle on this change before pushing it to the weekly snapshot).
> Sorry, I wasn't clear. I didn't mean to update the tests with the sample
> failing output. I always like to put that stuff in the bug report.
Ah, OK. I had put some explanations in the bug report, and linked the
related failures.
> I think you should be the one to lower the priority of _both_ bugs
> with the explanation that you have given above.
Done.
>> Hmmm... I think you are right. Do you want me to relink these
>> appropriately?
>
> Yes, please.
Done.
-Aleksey.
More information about the hotspot-runtime-dev
mailing list