RFR #2 (S) CR 8015270: @Contended: fix multiple issues in the layout code
Daniel D. Daugherty
daniel.daugherty at oracle.com
Mon May 27 12:45:54 PDT 2013
On 5/27/13 1:43 PM, Aleksey Shipilev wrote:
> On 05/27/2013 11:27 PM, Daniel D. Daugherty wrote:
>> On 5/27/13 1:21 PM, Daniel D. Daugherty wrote:
>>> On 5/27/13 1:16 PM, Aleksey Shipilev wrote:
>>>> Yeah, well, my puristic self anyway thinks "one issue" = "one CR" is a
>>>> better idea. :) Do you want the generated changeset for this webrev? (I
>>>> also want to tickle my paranoia a little and suggest we wait for the
>>>> nightly cycle on this change before pushing it to the weekly snapshot).
>>> That's always the minimum because we only push bits that have been
>>> through one night of testing. Of course, there have been exceptions,
>>> but those require 3-4 code reviewers, some spot testing, the sacrifice
>>> of a goat or two... :-)
>> The JPRT-hotspotwest queue is clear at the moment.
>>
>> I see reviews from Vladimir, Coleen, David H and me. Actually I'm not
>> sure if David H considers himself to be a full reviewer, but you may
>> know different. It looks like all the testing questions are addressed...
>>
>> If you have a changeset ready, I can get it into the JPRT-hotspotwest
>> queue... Of course, the queue might fill up while I'm typing...
> I was not having a changeset, but I had just generated one:
> http://cr.openjdk.java.net/~shade/8015270/8015270.changeset
>
> -Aleksey.
>
Fails jcheck. I'll fix it up.
Dan
More information about the hotspot-runtime-dev
mailing list