RFR (S) 8014905: Some hotspot tests should be updated to divide test jdk and compile jdk

[Yumin Qi]

Chris,

   Changes looks good. Names create<Compile/Test>JDK are strange, we do 
not 'create' jdks, get path in fact, right?

Thanks
Yumin

On 5/29/2013 1:52 PM, Christian Tornqvist wrote:
>
> Updated webrev based on feedback from Mattis Castegren (who also 
> provided the JDKToolLauncher Test included in this webrev). Added some 
> code to use the java.home system property if test.jdk / compile.jdk is 
> not present. This should remove the need manually set this property if 
> running test outside of jtreg.
>
> Webrev can be found at:
>
> http://cr.openjdk.java.net/~ctornqvi/webrev/8014905/webrev.01/ 
> <http://cr.openjdk.java.net/%7Ectornqvi/webrev/8014905/webrev.01/>
>
> Thanks,
>
> Christian
>
> *From:*hotspot-runtime-dev-bounces at openjdk.java.net 
> [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] *On Behalf Of 
> *Christian Tornqvist
> *Sent:* den 29 maj 2013 08:06
> *To:* gary.collins at oracle.com; hotspot-runtime-dev at openjdk.java.net
> *Subject:* RE: RFR (S) 8014905: Some hotspot tests should be updated 
> to divide test jdk and compile jdk
>
> Hi,
>
> Still looking for reviewers for this.
>
> Thanks,
>
> Christian
>
> *From:*hotspot-runtime-dev-bounces at openjdk.java.net 
> <mailto:hotspot-runtime-dev-bounces at openjdk.java.net> 
> [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] *On Behalf Of 
> *Christian Tornqvist
> *Sent:* den 23 maj 2013 16:22
> *To:* gary.collins at oracle.com <mailto:gary.collins at oracle.com>; 
> hotspot-runtime-dev at openjdk.java.net 
> <mailto:hotspot-runtime-dev at openjdk.java.net>
> *Subject:* RFR (S) 8014905: Some hotspot tests should be updated to 
> divide test jdk and compile jdk
>
> Hi everyone,
>
> Could I please have some reviews for this small test (library) fix. 
> The following tests:
>
> gc\TestG1ZeroPGCTJcmdThreadPrint.java
>
> gc\TestVerifyDuringStartup.java
>
> runtime\NMT\BaselineWithParameter.java
>
> runtime\NMT\JcmdScale.java
>
> runtime\NMT\JcmdWithNMTDisabled.java
>
> runtime\NMT\MallocTestType.java
>
> runtime\NMT\ShutdownTwice.java
>
> runtime\NMT\SummaryAfterShutdown.java
>
> runtime\NMT\SummarySanityCheck.java
>
> runtime\NMT\ThreadedMallocTestType.java
>
> runtime\NMT\ThreadedVirtualAllocTestType.java
>
> runtime\NMT\VirtualAllocTestType.java
>
> runtime\RedefineObject\TestRedefineObject.java
>
> use the JDKToolFinder.getJDKTool() method to get the path to different 
> tools in JDK\bin. This only works if the Java used in the test is a 
> full JDK build. If the Java used for testing is a JRE build the JDK 
> tools will be available as compile.jdk instead of test.jdk.
>
> The solution was to simply change the getJDKTool() method to use the 
> "compile.jdk" property to get the path to the tools (this will be set 
> by jtreg to the same value as test.jdk if '-compilejdk' is not 
> specified on the command line). I've also added getTestJDKTool() and 
> getCompileJDKTool() methods so that the tools can be explicitly 
> grabbed from either location if necessary.
>
> Webrev can be found at: 
> http://cr.openjdk.java.net/~ctornqvi/webrev/8014905/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ectornqvi/webrev/8014905/webrev.00/>
>
> Bug (not yet visible at time of posting): 
> http://bugs.sun.com/view_bug.do?bug_id=8014905
>
> Testing done was to run the above mentioned tests with jtreg using a 
> JRE and --compilejdk pointing to a JDK and then again without 
> --compilejdk but using a JDK to test.
>
> Thanks,
> Christian
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130529/07869131/attachment-0001.html