RFR (S): 6726963: multi_allocate() call does not CHECK_NULL and causes crash in fastdebug bits

[Yumin Qi]

Misha,

   Changes good (I am not a reviewer).

Thanks
Yumin

On 5/30/2013 10:25 AM, Mikhailo Seledtsov wrote:
>
> Hi,
>
> Please review this one-line fix,
>
>   and a test code to reproduce this bug.
>
> http://cr.openjdk.java.net/~ctornqvi/webrev/6726963/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ectornqvi/webrev/6726963/webrev.00/>
>
> Overview:
>
>      the test case attempts to test out-of-memory condition allocating 
> very large multi-dimensional array.
>
> JVM can throw OOM exception, but should not crash or except in any 
> other way.
>
> Fix:
>
> added a null-check when calling multi_allocate while allocating the 
> object in corresponding method
>
> of the reflection class
>
> Testing:
>
>     - Created a JTReg test case to reproduce this bug
>
>     - The test case fails before the fix, and passes after the fix.
>
> Tested on 32-bit Linux build.
>
>     - Ran this test case on all supported platforms using JPRT harness 
> - PASS
>
>     - Full JPRT run - PASS
>
>     - UTE run with vm.quick.testlist - NO new failures introduced by 
> this change
>
> Thank you,
>
> Misha
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130530/8b8bbef0/attachment.html