RFR (XS) 8028520: JVM should not throw VerifyError when a private method overrides a final method

[Keith McGuigan]

Ok, thanks.  Looks good then!


On Tue, Nov 19, 2013 at 12:52 PM, harold seigel <harold.seigel at oracle.com>wrote:

>  Hi Keith,
>
> Thanks for the review!
>
> Prior to the JDK 7u45 release, private methods were ignored when checking
> to see if a method overrides a final method.  This fix undoes the change
> made (only) to JDK 7u45 to include private methods in this check.  So, I
> don't think adding a class file version check is required.
>
> Thanks, Harold
>
>
>
> On 11/19/2013 11:08 AM, Keith McGuigan wrote:
>
> Code looks fine, but might you want to add a class file version check so
> that the behavior is unchanged for already-deployed classfiles?
>
>  --
> - Keith
>
>
> On Tue, Nov 19, 2013 at 10:57 AM, harold seigel <harold.seigel at oracle.com>wrote:
>
>> Hi,
>>
>> Please review this small fix for bug 8028520.  Ina greement with a recent
>> JVM Spec  change this fix ignores private methods when checking to see if a
>> method is overriding a final method.
>>
>> webrev: http://cr.openjdk.java.net/~hseigel/bug_8028520/ <
>> http://cr.openjdk.java.net/%7Ehseigel/bug_8028520/>
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8028520
>>
>> The fix was tested with JCK Lang and VM tests, ute quicktests, jtreg, and
>> defmeth tests.
>>
>> Thanks, Harold
>>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20131119/f004eb2f/attachment.html