RFR (XXS): 8025845: Default methods are unnecessarily marked w/ force_inline directive

[Vladimir Ivanov]

Karen,

Thank you.

I spot this issue while looking though compilation log investigating 
completely unrelated bug. Was really surprised seeing "force inline by 
annotation" for some library method :-)

Best regards,
Vladimir Ivanov

On 10/3/13 1:23 AM, Karen Kinnear wrote:
> Vladimir,
>
> Fix looks good.
>
> If you are looking at performance with lambda, you should know that with 8009130, which is in code review,
> the overpasses that are generated for default methods go away, only leaving the generated code for exceptions,
> so this issue should be seriously reduced.
>
> thanks,
> Karen
>
> On Oct 2, 2013, at 4:34 PM, Vladimir Ivanov wrote:
>
>> http://cr.openjdk.java.net/~vlivanov/8025845/webrev.00/
>> 1 line changed: 0 ins; 1 del
>>
>> Default methods may be marked with force_inline directive, which forces JIT compiler to unconditionally inline them during compilation. It may disturb inlining decisions JIT compiler makes causing generation of suboptimal code and performance regressions.
>>
>> Testing: verified that a default method isn't unconditionally inlined which was inlined before the fix.
>>
>> Thanks!
>>
>> Best regards,
>> Vladimir Ivanov
>>
>> https://bugs.openjdk.java.net/browse/JDK-8025845
>