RFR: patch for avoiding "unknown MS VC++: 1600"

[Daniel D. Daugherty]

This change was done in HSX-25 using the following:

$ hg log -r 4332 src/share/vm/runtime/vm_version.cpp
changeset:   4332:9960dce2024f
parent:      4291:b7c2c5b2572c
user:        kmo
date:        Thu Mar 14 13:22:04 2013 -0700
summary:     8010116: Abstract_VM_Version::internal_vm_info_string() 
should recognize VS2010 and VS2012

$ hg diff -r 4291 -r 4332 src/share/vm/runtime/vm_version.cpp
diff -r b7c2c5b2572c -r 9960dce2024f src/share/vm/runtime/vm_version.cpp
--- a/src/share/vm/runtime/vm_version.cpp       Wed Feb 13 10:25:09 2013 
+0100
+++ b/src/share/vm/runtime/vm_version.cpp       Thu Mar 14 13:22:04 2013 
-0700
@@ -211,6 +211,10 @@ const char* Abstract_VM_Version::interna
          #define HOTSPOT_BUILD_COMPILER "MS VC++ 8.0 (VS2005)"
        #elif _MSC_VER == 1500
          #define HOTSPOT_BUILD_COMPILER "MS VC++ 9.0 (VS2008)"
+      #elif _MSC_VER == 1600
+        #define HOTSPOT_BUILD_COMPILER "MS VC++ 10.0 (VS2010)"
+      #elif _MSC_VER == 1700
+        #define HOTSPOT_BUILD_COMPILER "MS VC++ 11.0 (VS2012)"
        #else
          #define HOTSPOT_BUILD_COMPILER "unknown MS VC++:" XSTR(_MSC_VER)
        #endif

I don't think we want to add VS2012 to HSX-24 so this wouldn't be a
straight backport. I've moved:

     JI-9007225 -Xinternal version displays with unknown MS VC++:1600 
for VS2010

to:

     JDK-8025882 -Xinternal version displays with unknown MS VC++:1600 
for VS2010

Dan


On 10/3/13 1:53 AM, Francis ANDRE wrote:
> Hi
>
> Running make test_jdk on a WXP/x86/VS2010 displays this message
>
> $ make test_jdk
> /cygdrive/z/DEV/OpenJDK_7u40/hotspot/build/windows/jdk-windows-i586/bin/java 
> -d32 -client -Xinternal
> version
> OpenJDK Client VM (24.0-b56-internal) for windows-x86 JRE (1.7.0), 
> built on Oct  3 2013 08:33:06 by
> "FrancisANDRE" with unknown MS VC++:1600
>
>
> Here the patch for correcting the MS VC++ version
>
> diff --git a/src/share/vm/runtime/vm_version.cpp 
> b/src/share/vm/runtime/vm_version.cpp
> --- a/src/share/vm/runtime/vm_version.cpp
> +++ b/src/share/vm/runtime/vm_version.cpp
> @@ -209,6 +209,8 @@
>          #define HOTSPOT_BUILD_COMPILER "MS VC++ 8.0 (VS2005)"
>        #elif _MSC_VER == 1500
>          #define HOTSPOT_BUILD_COMPILER "MS VC++ 9.0 (VS2008)"
> +      #elif _MSC_VER == 1600
> +        #define HOTSPOT_BUILD_COMPILER "MS VC++ 10.0 (VS2010)"
>        #else
>          #define HOTSPOT_BUILD_COMPILER "unknown MS VC++:" XSTR(_MSC_VER)
>        #endif
>
> Francis