RFR: Lambda: 8009130 JCK lambda test fails with IllegalAccessException

Coleen Phillmore coleen.phillimore at oracle.com
Sun Oct 6 16:18:33 PDT 2013


On 10/6/2013 4:15 PM, Karen Kinnear wrote:
>> 1169       if (m->method_holder()->is_interface() &&
>> 1170           !m->is_abstract()) {
> Done. Coleen will like this - thanks!

Definitely!   One of the benefits of being slow to the review.

Karen, thank you for going over this code with me on the phone.   I 
think it looks good.   I have one request for a comment in 
InstanceKlass::deallocate_contents() where I you don't delete the 
methods in the default_methods array - ie.  These methods are owned by 
super-classes and super-interfaces so don't delete them (or some such).

Also the pattern in dependencies.cpp and jni.cpp is the same    The 
difference between find_method and lookup_method in InstanceKlass is 
subtle.   I think it would help to have a function with this pattern 
refactored as lookup_method_including_interfaces() with a comment that 
this looks in the default_methods array also.   I searched through and 
don't see any other places where I think this might have been missed.

I don't have any additional comments.   This does look good.
Thanks,
Coleen


More information about the hotspot-runtime-dev mailing list