S RFR ASAP: 8026185: 8009130 broke GetMethodDeclaringClass/declcls001

[harold seigel]

Hi Karen,

Your fix for the refactoring problem looks good.

Harold

On 10/9/2013 4:10 PM, Coleen Phillimore wrote:
>
> I see your refactoring bug:
>
> 1461   Method* m;
>
> Is uninitialized so it was returning junk.   You can fix this either 
> way, I understand the urgency.
>
> Coleen
>
> On 10/9/2013 3:47 PM, Karen Kinnear wrote:
>> Folks,
>>
>> webrev:http://cr.openjdk.java.net/~acorn/8026185/webrev/
>> bug:https://bugs.openjdk.java.net/browse/JDK-8026185
>>
>> After all the code reviews for 8009130, Monday morning I did a small amount of refactoring and messed that up.
>> It broke in hotspot-rt nightly, so I need to get the fix in TODAY.
>>
>> The code changes here go back to the code that Yumin, Serguei and Coleen actually did review
>> and which was extensively tested.
>>
>> Testing (in progress)
>> linux:
>> nsk/jvmti/GetMethodDeclaringClass/declcls001 (002, 003)
>> jck api/java_tuil/TreeSet/ParallelStream.html (dependencies.cpp use case)
>> vm.quick.testlist
>>
>>    which includes nsk/regression/b4226863 and nsk/stress/jck12a/jck12a009
>> Solaris:
>>    vm.quick-dtrace.testlist which includes
>>    8026217: dtrace/hotspot_jni/ALL/ALL001
>>
>> thanks,
>> Karen
>>
>> p.s. you can compare to these parts of the files you reviewed in
>> http://cr.openjdk.java.net/~acorn/8009130.4/webrev/
>>
>> which incorporated comments from Lois, Yumin and Serguei and Coleen's naming change
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20131009/e2463f66/attachment.html