RFR (S) 8024667: VM crashes with "assert(method() != NULL) failed: must have set method"

[Coleen Phillimore]

Harold,

I think this looks good.  It would be nice to not have to check 
is_shared() everywhere in InstanceKlass::deallocate_contents() but we 
want to zero the fields so I think it's ok.

Thanks,
Coleen

On 10/10/2013 09:59 AM, harold seigel wrote:
> Hi,
>
> Please review this fix for bug 8024667.  The problem occurred because 
> function InstanceKlass::deallocate_contents() was erroneously 
> deallocating memory that was in the CDS shared region. This change 
> fixes the problem by checking if the memory is in the shared region 
> before allowing the deallocation.  The change also added asserts as an 
> additional check.
>
> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8024667/ 
> <http://cr.openjdk.java.net/%7Ehseigel/bug_8024667/>
>
> Bug Link: https://bugs.openjdk.java.net/browse/JDK-8024667
>
> The fix was tested with JPRT and with UTE and JTREG tests with both 
> -client and -server.  It was also tested using the failed tests that 
> were reported in bugs 8024667 and 8026055.
>
> Thanks, Harold