S RFR: 8026299 Lambda: Invokespecial gets an IncompatibleClassChangeError when it should get AbstractMethodError

Karen Kinnear karen.kinnear at oracle.com
Mon Oct 14 10:59:32 PDT 2013


Thank you Calvin for testing this and for the code review.
I rejoined the lines, my editor throws in extra lines
On Oct 11, 2013, at 6:51 PM, Calvin Cheung wrote:

> Karen,
> 
> I've tried your patch and it passes the testSuperNull and testSuperNonDefault1 tests.
> 
> nit: (in lineResolver.cpp)
> 873   resolve_method(resolved_method, resolved_klass, method_name,
> 874 method_signature, current_klass, check_access, false, CHECK);
> 
> needs some indentation in line 874 or just join those 2 lines together.
> 
> thanks,
> Calvin
> 
> On 10/11/2013 2:02 PM, Karen Kinnear wrote:
>> Thanks Calvin - fixed the webrev link.
>> 
>> thanks,
>> Karen
>> On Oct 11, 2013, at 4:39 PM, Karen Kinnear wrote:
>> 
>>> Please review:
>>> 
>>> webrev: http://cr.openjdk.java.net/~acorn/8026299/webrev/
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8026299
>>> 
>>> Bug in linkResolver handling of ICCE for getting an interfacemethodref - should only apply to invokevirtual with latest spec.
>>> 
>>> Tested:
>>> Fixes vm.nsk.defmeth.DefaultMethodTests.SuperCallTest
>>> testSuperNull: 1-3
>>> testSuperNonDefault1
>>> 
>>> DefaultMethodsTests
>>> jck.vm
>>> jck.lang
>>> vm.quick.testlist
>>> 
>>> thanks,
>>> Karen
> 



More information about the hotspot-runtime-dev mailing list