RFR ASAP please: 8026365: Fix verifier for anonymous classes
Karen Kinnear
karen.kinnear at oracle.com
Thu Oct 17 07:27:20 PDT 2013
Thank you very much Keith.
thanks,
Karen
On Oct 17, 2013, at 10:10 AM, Keith McGuigan wrote:
> The code looks fine. I don't know how this jives with the new version of the spec but I'll assume you've got it right here :)
>
>
> On Thu, Oct 17, 2013 at 10:05 AM, Keith McGuigan <kmcguigan at twitter.com> wrote:
> I'm not able to access the bug in JIRA. It give me a permission violation message :(
>
>
> On Thu, Oct 17, 2013 at 12:13 AM, Karen Kinnear <karen.kinnear at oracle.com> wrote:
> Please review quickly:
>
> webrev: http://cr.openjdk.java.net/~acorn/8026365/webrev/
> bug: https://bugs.openjdk.java.net/browse/JDK-8026365
>
> Verifier called is_reference_assignable, which called resolve_or_null, which was looking for
> the anonymous class in the system dictionary, where it is not. So this will allow more anonymous
> class cases to get through the verifier while still doing validity checking (but on the host class only,
> not on the anonymous class).
>
> Tested:
> Robert's new test: reduct (which he will check in as part of the lambda side of this change)
> Lam
> Lam1
>
> in progress: vm.quick, java.lang, java.util, Nashorn
>
> thanks,
> Karen
>
> p.s. Alejandro, Dan, Calvin - they want this in TL ASAP - should I check this directly into hotspot-master tomorrow?
>
> p.s. Vincente - can you grab this patch to test with Robert's changes please? I tested with the patches he
> had given me
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20131017/08af9396/attachment.html
More information about the hotspot-runtime-dev
mailing list