RFR (S) JDK-8026394: Eclipse fails with JDK8 build 111

[David Holmes]

Hi Lois,


On 22/10/2013 9:58 AM, Lois Foltan wrote:
> Please review the following fix:
>
> Webrev:
>      http://cr.openjdk.java.net/~hseigel/bug_jdk8026394/
>
> Bug: Eclipse fails with JDK8 build 111
>      https://bugs.openjdk.java.net/browse/JDK-8026394
>
> Summary of fix:
>      If a direct interface of a class does not declare "clone" or
> "finalize" methods, the selection process
>      looks to the interface's super class, java.lang.Object.  With the
> JDK 8 interface accessability
>      check requirement, since these methods are declared within Object
> as protected, an IAE would
>      result.  In order to support pre-existing Java code,
> LinkResolver::check_method_accessability()
>      must check for and special case these two methods.

I must confess that I'm a bit confused by the problem and the solution. 
Just looking at the test you define public clone and finalize methods in 
the interface and you implement them in the class as public - so why 
would Object's protected variants even get a look-in in this scenario 
??? It seems to me, likely naively, that the issue is not being unable 
to access Object's clone/finalize because they are protected, but even 
looking at Object's methods in the first place!

That aside - Unrelated to your changes but can you fix the duplicated 
copyright line please:

   2  * Copyright (c) 1997, 2013, Oracle and/or its affiliates. All 
rights reserved.
    3  * Copyright (c) 1997, 2013, Oracle and/or its affiliates. All 
rights reserved.

Thanks,
David

> Tests:
>      Completed - jtreg, vm.quick.testlist, jck vm & lang
>      In progress - jdk java.lang & java.util
>
> Thank you, Lois