RFR (S) 8026822: metaspace/flags/maxMetaspaceSize throws OOM of unexpected type ava.lang.OutOfMemoryError: Compressed class space

[harold seigel]

Hi Coleen,

I can make those changes.  Thanks for the review.

Harold

On 10/24/2013 1:39 PM, Coleen Phillimore wrote:
>
> Hi Harold,
>
> Besides the odd abbreviation and indentation, I think this improves 
> the error message.  These are cosmetic comments.
>
> *out_of_cmprsd_class_space => out_of_compressed_class_space*
> *+       out_of_cmprsd_class_space =*
> *+         MetaspaceAux::committed_bytes(Metaspace::ClassType) +*
> *+           metaspace->class_vsm()->calc_chunk_size(word_size) * BytesPerWord*
> *+         > CompressedClassSpaceSize;
>
> Can this be a Metaspace function, ie Metaspace::class_chunk_size(word_size)?  To hide class_vsm()?
>
> **+       out_of_compressed_class_space =*
> *+         (MetaspaceAux::committed_bytes(Metaspace::ClassType) +*
> *+          metaspace->class_chunk_size(word_size)) > CompressedClassSpaceSize;*
>
> Thanks,
> Coleen
>
> On 10/24/2013 1:02 PM, harold seigel wrote:
>> Hi,
>>
>> Please review this fix for bug 8026822.  The fix incorporates the 
>> requested chunk size when determining whether the OutOfMemoryError 
>> was caused by running out of Metaspace or Compressed class space.
>>
>> Open webrev at: http://cr.openjdk.java.net/~hseigel/bug_8026822/ 
>> <http://cr.openjdk.java.net/%7Ehseigel/bug_8026822/>
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8026822
>>
>> The fix was tested with UTE vm.metaspace, vm.mlvm, vm.quick, and 
>> jtreg tests on Linux and vm.metaspace tests on Solaris.
>>
>> Thanks! Harold
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20131024/c80a3587/attachment.html