S RFR: 8027304: Lambda: inheriting abstract and default should invoke default, not ICCE

Karen Kinnear karen.kinnear at oracle.com
Wed Oct 30 06:06:25 PDT 2013


Harold,

That is much clearer - I will do that. With that change does this count as a code review :-)?

thanks,
Karen

On Oct 30, 2013, at 8:37 AM, harold seigel wrote:

> Hi Karen,
> 
> Instead of:
> unique_default = (unique_default == false) ? true : false; 
> why not just:
> unique_default = !unique_default;
> Thanks, Harold
> 
> On 10/29/2013 10:55 PM, Karen Kinnear wrote:
>> webrev: http://cr.openjdk.java.net/~acorn/8027304/webrev/
>> bug: http://bugs.openjdk.java.net/browse/JDK-8027304
>> 
>> Bug in default method handling due to specification misinterpretation if there is one maximally-specific default method, 
>> but no one maximally specific method based on default method inheritance rules.
>> Inheritiing abstract and default should invoke default, rather than IncompatibleClassChangeError.
>> 
>> Tested:
>> Fixed vm defmeth ConflictingDefaultsTest testAmbiguousReabstract (renamed to testMaximallySpecificDefault)
>> jdk DefaultMethodsTest, FDSeparateCompilationTest
>> jck lang, vm
>> jtreg java.util, java.lang
>> vm.quick.testlist
>> 
>> thanks,
>> Karen
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20131030/2ace15dd/attachment.html 


More information about the hotspot-runtime-dev mailing list