RFR (M): 8027237: tests on ReservedSpace/VirtualSpace

[Zhengyu Gu]

OK. Looks good to me.

-Zhengyu

On 10/30/2013 9:43 AM, aleksey.timofeev at oracle.com wrote:
> Hi Zhengyu,
>
> Thanks for response.
>
> Yes, Whitebox API is exported in product build and is enabled by 
> special command line flags.
>
> Body of method "WB_RunMemoryUnitTests" running unit tests is 
> surrounded by #ifndef PRODUCT because unit tests (those who launched 
> by option -XX:+ExecuteInternalVMTests) presence only in debug build. 
> This method launches subset of unit tests.
>
> >Hi Aleksey,
> >
> >I wonder what's the reason for "#ifndef PRODUCT", do we export whitebox
> >API in product VM? If yes, why they are different from the others?
> >
> >Thanks,
> >
> >-Zhengyu
> >
> >
> >On 10/29/2013 12:33 PM, aleksey.timofeev at oracle.com wrote:
> >> Hello.
> >>
> >> Would somebody please review my new tests on ReservedSpace and
> >> VirtualSpace classes? Looks like I have one agreeable reviewer from gc
> >> team. I want the second to be from runtime team as these tests are
> >> about to go to runtime folder.
> >>
> >> 
> http://cr.openjdk.java.net/~iignatyev/atimofeev/ResVirtSpaceTests/webrev.04/ 
>
> >> 
> <http://cr.openjdk.java.net/%7Eiignatyev/atimofeev/ResVirtSpaceTests/webrev.04/> 
>
> >>
> >>
> >> Please, don't ignore this review request.
> >>
> >> Also It would be great if somebody sponsor this commit apart from just
> >> reviewing.
> >>
>