RR(XS): JDK-8024056 runtime/InitialThreadOverflow/testme.sh fails

Dmitry Samersoff dmitry.samersoff at oracle.com
Tue Sep 3 00:57:55 PDT 2013


David,

> The == should just be =

I changed it as well. see ll 47 of webrev.

-Dmitry


On 2013-09-03 02:55, David Holmes wrote:
> Hi Dmitry,
> 
> On 3/09/2013 5:38 AM, Dmitry Samersoff wrote:
>> Hi Everybody,
>>
>> http://cr.openjdk.java.net/~dsamersoff/JDK-8024056/webrev.01/
>>
>> Please review small correction to the test.
>>
>> On some linuxes gcc not able to link cxx binary. Explicitly check for g++
> 
> That seems okay but you have no addressed this problem:
> 
> + [ x/usr/bin/gcc == x ]
> [: 1: x/usr/bin/gcc: unexpected operator
> 
> There are a couple of tests using this kind of construct:
> 
>   46 gcc_cmd=`which gcc`
>   47 if [ "x$gcc_cmd" == "x" ]; then
>   48     echo "WARNING: gcc not found. Cannot execute test." 2>&1
>   49     exit 0;
>   50 fi
> 
> The == should just be =
> 
> Thanks,
> David
> 
>> -Dmitry
>>


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the source code.


More information about the hotspot-runtime-dev mailing list