RFR: 7164841: Improvements to the GC log file rotation
Thomas Schatzl
thomas.schatzl at oracle.com
Wed Sep 11 08:11:43 PDT 2013
Hi Yumin,
On Mon, 2013-09-09 at 12:11 -0700, Yumin Qi wrote:
> Hi, Thomas and all
>
> This is a new version,
> http://cr.openjdk.java.net/~minqi/7164841/webrev04/
> <http://cr.openjdk.java.net/%7Eminqi/7164841/webrev04/>
>
> There is an existing method, make_log_name which converts %p to
> <1234>, so I decided to modify it to include converting %t to
> YYYY-MM-DD_HH-MM-SS. The function extend_file_name is not needed then.
> The name limitation is only for file name not path, in case user has
> special characters used in their path name.
>
> rotatingFileStream is renamed to gcLogFileStream, and handle both
> logging (normal) and rotating work.
>
> A problem observed when user gives an wrong path, say,
> -Xloggc:/temp/temp/test.log, /temp/temp does not exist, in this case, I
> only give a warning and not exit from VM, should app exit VM in such
> case? After warning, app still can run but no log.
I'm still looking at this, but could you make some test cases for the %
p/t file name replacement using the VM internal testing
"infrastructure"?
I.e. enabled by the ExecuteInternalVMTests option?
Thanks,
Thomas
More information about the hotspot-runtime-dev
mailing list