RFR (S) 8024517: runtime/CDSCompressedKPtrs/XShareAuto.java failed with RuntimeException

[David Holmes]

Hi Harold,

Sorry I am a bit confused about the problem and solution. CDS should be 
off when using the server VM - right? But this code:

! #ifndef COMPILER2
!   if (is_server_class_mach)
! #endif

only affects the client VM, so you seem to be saying that CDS should be 
off on a client VM when running on a server class machine ???

David

On 14/09/2013 5:05 AM, harold seigel wrote:
> Hi,
>
> Please review this small fix for bug 8024517.  This test failed when run
> on a small system because CDS was not disabled by default. Although the
> test was run with '-server', CDS was not disabled because function
> os::is_server_class_machine() returned FALSE.  This fix disables CDS by
> default if either os::is_server_class_machine() returns TRUE or the
> server compiler is running.
>
> Also, the '-server' option was added to the test's '-Xshare:dump'
> command to ensure that the CDS region gets created by the same JVM that
> tries to read it.
>
> The change was tested with the XShareAuto.java test, by hand using the
> NeverActAsServerClassMachine and AlwaysActAsServerClassMachine options,
> the UTE vm quicktests, and JPRT.
>
> Open webrev at: http://cr.openjdk.java.net/~hseigel/bug_8024517/
> <http://cr.openjdk.java.net/%7Ehseigel/bug_8024517/>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8024517
>
> Thanks! Harold