S RFR: Lambda: no superclass methods in defaults

[Yumin Qi]

Karen,

  Only a minor comments:

1)   The last comma of line 1109 can be removed.  Better replace 'and' 
in line 1113 with 'if':

1108 // A "bridge" is a method created by javac to bridge the gap between
1109 // an implementation and a generically-compatible, but different, signature.
1110 // Bridges have actual bytecode implementation in classfiles.
1111 // An "overpass", on the other hand, performs the same function as a bridge
1112 // but does not occur in a classfile; the VM creates overpass itself,
1113 // when it needs a path to get from a call site to an default method, and
1114 // a bridge doesn't exist.

2)

1141 #endif // ndef PRODUCT

remove 'ndef'.

Thanks
Yumin



On 9/13/2013 8:24 PM, Karen Kinnear wrote:
> Please review
>
> webrev: http://cr.openjdk.java.net/~acorn/8024647.01/webrev/
> https://bugs.openjdk.java.net/browse/JDK-8024647
>
> Bug: Default method resolution incorrectly handles private superclass methods.
> Problem was that during default method resolution, we are creating overpasses for
> superclass target methods. We only need to create these for superinterface target methods.
>
> Testing:
> test cases in the bug
> defmeth tests - no additional failures
>    (these test cases should be added to the vm sqe defmeth tests)
>
> regression tests:
> java.util.streams - in progress
> jprt - in progress
> vm.quick.testlist - in progress
>
> thanks,
> Karen
>
>