RFR (S) 8023956 [2nd post]: Provide a work-around to broken Linux 32 bit "Exec Shield" using CS for NX emulation (crashing with SI_KERNEL)

[Zhengyu Gu]

Look good to me.

Thanks,

-Zhengyu

On 9/24/2013 4:17 AM, David Simms wrote:
> Hi Zhengyu,
>
> So the work around code executes in early start up (os::init_2) before 
> MemTracker is bootstrapped, but yeah (to cover any future additions), 
> using top level os::reserve/commit methods, patch updated:
>
> http://cr.openjdk.java.net/~dsimms/8023956/ 
> <http://cr.openjdk.java.net/%7Edsimms/8023956/>
>
> Cheers
>
>
> On 09/23/2013 05:25 PM, Zhengyu Gu wrote:
>> Hi David,
>>
>> /src/os_cpu/linux_x86/vm/os_linux_x86.cpp #906
>>
>> The mmap() call needs to be reported to native memory tracking.
>>
>> Thanks,
>>
>> -Zhengyu
>>
>> On 9/23/2013 8:27 AM, Coleen Phillmore wrote:
>>>
>>> David,
>>> This looks really good.   Thank you for adding this workaround.   
>>> Should you remove the SI_KERNEL message that we have in the signal 
>>> handler too?
>>> Thanks,
>>> Coleen
>>>
>>> On 9/23/2013 5:02 AM, David Simms wrote:
>>>>
>>>>
>>>>
>>>> -------- Original Message --------
>>>> Subject: 	RFR (S) 8023956: Provide a work-around to broken Linux 32 
>>>> bit "Exec Shield" using CS for NX emulation (crashing with SI_KERNEL)
>>>> Date: 	Mon, 02 Sep 2013 13:18:52 +0200
>>>> From: 	David Simms <david.simms at oracle.com>
>>>> To: 	hotspot-runtime-dev at openjdk.java.net
>>>>
>>>>
>>>>
>>>> G'day all,
>>>>
>>>> Please review a small enhancement for working around a rare but 
>>>> annoying Linux bug (ia32 only).
>>>>
>>>> Bug link: https://bugs.openjdk.java.net/browse/JDK-8023956 ( 
>>>> http://bugs.sun.com/view_bug.do?bug_id=8023956)
>>>>
>>>> Webrev: http://cr.openjdk.java.net/~dsimms/8023956/ 
>>>> <http://cr.openjdk.java.net/%7Edsimms/8023956/>
>>>>
>>>> Cheers
>>>> /David Simms
>>>>
>>>>
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130924/0366d99b/attachment.html